10000 Fix: #6996 Fixed Sorting of Next Maintenance Column in Hangar by IllianiBird · Pull Request #7002 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #6996 Fixed Sorting of Next Maintenance Column in Hangar #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

IllianiBird
Copy link
Collaborator

Fix #6996

The use of individual characters for mothballed units was breaking sorting. Now it isn't. I also added in natural language sorting so that it would sort more cleanly.

@IllianiBird IllianiBird self-assigned this May 14, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 14, 2025 18:52
@IllianiBird IllianiBird added Bug GUI Severity: High Issues described as high severity as per the new issue form labels May 14, 2025
Copy link
codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (721f292) to head (3bde410).
Report is 100 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/model/UnitTableModel.java 0.00% 2 Missing ⚠️
MekHQ/src/mekhq/gui/HangarTab.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7002      +/-   ##
============================================
- Coverage     12.04%   12.03%   -0.01%     
- Complexity     6854     6855       +1     
============================================
  Files          1101     1101              
  Lines        141438   141442       +4     
  Branches      21919    21918       -1     
============================================
- Hits          17033    17023      -10     
- Misses       122579   122599      +20     
+ Partials       1826     1820       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird added Severity: Critical Issues described as critical as per the new issue form and removed Severity: High Issues described as high severity as per the new issue form labels May 14, 2025
@IllianiBird
Copy link
Collaborator Author

Elevating this to 'Critical' as I have since discovered it soft-locks the campaign and the issue persists after reloading.

Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sleet01 Sleet01 merged commit 5b6d021 into MegaMek:master May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Critical Issues described as critical as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] 0.50.06-nightly-2025-05-14 - NPE when sorting by next maintenance cycle in hangar status view
2 participants
0