Fix: Fixed Skill Modifiers Not Being Factored into Profession Experience Level #7014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3924,7 +3924,7 @@ | |||
| return SkillType.EXP_NONE; | |||
| } | |||
|
|
|||
| int individualSkillLevel = skill.getLevel(); | |||
| int individualSkillLevel = skill.getTotalSkillLevel(); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
There was a problem hiding this comment.
This will be handled by the upcoming implementation of Attribute Score modifiers.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7014 +/- ##
=========================================
Coverage 11.98% 11.98%
+ Complexity 6860 6858 -2
=========================================
Files 1102 1102
Lines 142197 142142 -55
Branches 21989 21977 -12
=========================================
- Hits 17039 17035 -4
+ Misses 123333 123288 -45
+ Partials 1825 1819 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experience level calculations for professions (green, regular, etc) were not correctly factoring in modifiers to that skill. This would have been something fixed by the 50.07 change to attribute scores, but might as well be corrected now as it's more obvious following my update to experience level calculations.