8000 Fix: Fixed Weight Calculation Visual Bug in StratCon Campaigns by IllianiBird · Pull Request #7015 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Fixed Weight Calculation Visual Bug in StratCon Campaigns #7015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

IllianiBird
Copy link
Collaborator

We were factoring in the 'Player Vehicles Weigh 50%' Legacy AtB option, even when StratCon is enabled. Now that option is only used if StratCon is disabled.

This is a visual bug only.

@IllianiBird IllianiBird self-assigned this May 15, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 15, 2025 20:44
@IllianiBird IllianiBird added Bug AtB GUI StratCon Bugs relating strictly to StratCon Severity: Low Issues described as low severity as per the new issue form labels May 15, 2025
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 11.98%. Comparing base (4f3213e) to head (a516535).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/force/CombatTeam.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7015      +/-   ##
============================================
- Coverage     11.98%   11.98%   -0.01%     
+ Complexity     6860     6857       -3     
============================================
  Files          1102     1102              
  Lines        142197   142144      -53     
  Branches      21989    21978      -11     
============================================
- Hits          17039    17031       -8     
+ Misses       123333   123290      -43     
+ Partials       1825     1823       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS merged commit 814dd97 into MegaMek:master May 16, 2025
6 checks passed
@IllianiBird IllianiBird deleted the weightCalculationsFix branch June 7, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB Bug GUI Severity: Low Issues described as low severity as per the new issue form StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0