8000 Fix: Fixed Missing Wordwrap from Command Rights Tooltips by IllianiBird · Pull Request #7016 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Fixed Missing Wordwrap from Command Rights Tooltips #7016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

IllianiBird
Copy link
Collaborator

The lengthy command rights tooltips were missing word wrapping. Now they're not.

@IllianiBird IllianiBird self-assigned this May 15, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 15, 2025 20:50
@IllianiBird IllianiBird added Bug GUI Severity: Medium Issues described as medium severity as per the new issue form labels May 15, 2025
Copy link
codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (f58a24d) to head (800ea6a).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/dialog/NewContractDialog.java 0.00% 2 Missing ⚠️
MekHQ/src/mekhq/gui/view/ContractSummaryPanel.java 0.00% 2 Missing ⚠️
MekHQ/src/mekhq/gui/view/MissionViewPanel.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7016   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6882     6887    +5     
=========================================
  Files          1102     1102           
  Lines        142171   142197   +26     
  Branches      21976    21985    +9     
=========================================
+ Hits          17115    17122    +7     
- Misses       123221   123244   +23     
+ Partials       1835     1831    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HammerGS HammerGS requested a review from Copilot May 16, 2025 00:02
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the missing word wrap in command rights tooltips by wrapping long text in a wordWrap call and updating the tooltip resource formatting. Key changes include updating tooltip method calls in MissionViewPanel and ContractSummaryPanel, adding a static import for wordWrap in NewContractDialog, and adjusting multiline text formatting in Mission.properties.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
MekHQ/src/mekhq/gui/view/MissionViewPanel.java Updated tooltip text to wrap long command rights descriptions.
MekHQ/src/mekhq/gui/view/ContractSummaryPanel.java Applied wordWrap to tooltip text for consistency.
MekHQ/src/mekhq/gui/dialog/NewContractDialog.java Added static import for wordWrap and updated pattern matching for tooltips.
MekHQ/resources/mekhq/resources/Mission.properties Reformatted multiline tooltip values; note potential typo in "Reflief Duty".

@HammerGS HammerGS merged commit b10c99b into MegaMek:master May 16, 2025
6 checks passed
@IllianiBird IllianiBird deleted the commandRightsTooltipWrapping branch June 7, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0