8000 Fix: Fixed Formatting Error in Title of Some Campaign Options Tabs by IllianiBird · Pull Request #7011 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Fixed Formatting Error in Title of Some Campaign Options Tabs #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Fix: Fixed Formatting Error in Title of Some Campaign Options Tabs #7011

merged 1 commit into from
May 16, 2025

Conversation

IllianiBird
Copy link
Collaborator

We were missing the html tags from a handful of tab headers. Now we're not.

@IllianiBird IllianiBird self-assigned this May 15, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 15, 2025 19:08
@IllianiBird IllianiBird added Bug GUI Campaign Options Relates to, or includes, campaign option changes Severity: Medium Issues described as medium severity as per the new issue form labels May 15, 2025
@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 11.98%. Comparing base (4f3213e) to head (9b54a8a).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...Options/components/CampaignOptionsHeaderPanel.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #7011   +/-   ##
=========================================
  Coverage     11.98%   11.98%           
+ Complexity     6860     6856    -4     
=========================================
  Files          1102     1102           
  Lines        142197   142143   -54     
  Branches      21989    21977   -12     
=========================================
- Hits          17039    17034    -5     
+ Misses       123333   123285   -48     
+ Partials       1825     1824    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerGS HammerGS merged commit 9f9a501 into MegaMek:master May 16, 2025
6 checks passed
@IllianiBird IllianiBird deleted the coIICFormattingError branch June 7, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug Campaign Options Relates to, or includes, campaign option changes GUI Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IllianiBird @Sleet01 @HammerGS
0