Fix: #7026 Fixed 'XP' Appearing Twice in Academy Tooltips #7028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7028 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
+ Complexity 6891 6890 -1
============================================
Files 1102 1102
Lines 142196 142200 +4
Branches 21984 21985 +1
============================================
- Hits 17131 17127 -4
- Misses 123230 123235 +5
- Partials 1835 1838 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the string "XP" was appearing twice in Academy tooltips by removing the explicit append of "XP".
- Removed the explicit "XP" from the tooltip construction in the Academy class.
- Retained the implicit mechanism for including "XP" in the tooltip.
Comments suppressed due to low confidence (1)
MekHQ/src/mekhq/campaign/personnel/education/Academy.java:803
- The removal of the explicit 'XP' appears correct, but please confirm that the implicit 'XP' addition is applied consistently, ensuring that tooltip information remains complete.
tooltip.append(skill).append(" (");
Scoppio
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7026
We were accidentally including an explicit 'XP' append as well as an implicit. Now we're just using the implicit.