Fix: (Sentry) Fixed Exception When Processing Education Tagalongs if Tagalong Has Exited the Campaign #7029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tagalong Has Exited the Campaign
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7029 +/- ##
============================================
- Coverage 12.04% 12.04% -0.01%
Complexity 6891 6891
============================================
Files 1102 1102
Lines 142196 142201 +5
Branches 21984 21986 +2
============================================
- Hits 17131 17125 -6
- Misses 123230 123246 +16
+ Partials 1835 1830 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Prevent null-pointer exception when updating education tagalongs if a tagalong has been removed.
- Added a null-check before invoking
changeStatuson each tagAlong - Retained logic to clear the
eduTagAlongslist after processing
Comments suppressed due to low confidence (2)
MekHQ/src/mekhq/campaign/personnel/Person.java:1349
- Use the passed-in
todayparameter instead ofcampaign.getLocalDate()when updatingtagAlongstatus to maintain consistency with the current status-change date.
tagAlong.changeStatus(campaign, campaign.getLocalDate(), PersonnelStatus.ACTIVE);
MekHQ/src/mekhq/campaign/personnel/Person.java:1345
- Add a unit test covering the scenario where
eduTagAlongscontains IDs not present in the campaign, verifying no exception occurs and the list is cleared correctly.
for (UUID tagAlongId : eduTagAlongs) {
Scoppio
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Sentry Report
If the player deleted one of a character's education tagalongs they'd be hit with an exception when we attempted to update the status of a tagalong when setting the character to a non-Student status.