8000 Fix: #7012 Properly update capacities when changing Transporters via refit by psikomonkie · Pull Request #7021 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: #7012 Properly update capacities when changing Transporters via refit #7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Fix: #7012 Properly update capacities when changing Transporters via refit #7021

merged 2 commits into from
May 15, 2025

Conversation

psikomonkie
Copy link
Collaborator

Fixes #7012

After a refit it was improperly updating the transport capacity. It was also not removing TransporterTypes that the unit no longer had. I added some nullable tags as well.

@psikomonkie psikomonkie requested a review from a team as a code owner May 15, 2025 21:54
IllianiBird
IllianiBird approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator
@IllianiBird IllianiBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out as an issue

@codecov Codecov
Copy link
codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (f5d3d11) to head (fedc839).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rc/mekhq/gui/menus/AssignForceToTransportMenu.java 0.00% 12 Missing ⚠️
...kHQ/src/mekhq/campaign/CampaignTransporterMap.java 40.00% 7 Missing and 2 partials ⚠️
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 3 Missing ⚠️
MekHQ/src/mekhq/campaign/unit/Unit.java 85.71% 0 Missing and 1 partial ⚠️
...ekhq/gui/menus/AssignForceToShipTransportMenu.java 0.00% 1 Missing ⚠️
.../gui/menus/AssignForceToTacticalTransportMenu.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #7021   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6882     6890    +8     
=========================================
  Files          1102     1102           
  Lines        142151   142171   +20     
  Branches      21977    21976    -1     
=========================================
+ Hits          17112    17119    +7     
- Misses       123202   123220   +18     
+ Partials       1837     1832    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psikomonkie psikomonkie changed the title Fix: #7012:Properly update capacities when changing Transporters via refit Fix: #7012 Properly update capacities when changing Transporters via refit May 15, 2025
@psikomonkie psikomonkie merged commit 75a0de1 into MegaMek:master May 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IllianiBird IllianiBird IllianiBird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Can't Assign BA into BA Factory Upgarde Variant Maxim in TOE after Refit
2 participants
@psikomonkie @IllianiBird
0