8000 Fix: Fixed Commander's Day Suppression by IllianiBird · Pull Request #7042 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Fixed Commander's Day Suppression #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Fix: Fixed Commander's Day Suppression #7042

merged 1 commit into from
May 18, 2025
+3 −1

Conversation

IllianiBird
Copy link
Collaborator

We weren't checking whether celebration announcements were enabled when triggering Commander's Day.

@IllianiBird IllianiBird self-assigned this May 18, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 18, 2025 02:34
@IllianiBird IllianiBird added Bug Severity: Medium Issues described as medium severity as per the new issue form labels May 18, 2025
@codecov Codecov
Copy link
codecov bot commented May 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 12.04%. Comparing base (b219024) to head (512ce49).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #7042   +/-   ##
=========================================
  Coverage     12.03%   12.04%           
- Complexity     6886     6892    +6     
=========================================
  Files          1102     1102           
  Lines        142200   142202    +2     
  Branches      21986    21988    +2     
=========================================
+ Hits          17120    17125    +5     
+ Misses       123247   123244    -3     
  Partials       1833     1833

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes May 18, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiBird IllianiBird merged commit 98213e7 into MegaMek:master May 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @Sleet01
0