8000 Fixed: Fixed Exception During Avionics Evaluation by IllianiBird · Pull Request #7051 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed: Fixed Exception During Avionics Evaluation #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2025
Merged

Fixed: Fixed Exception During Avionics Evaluation #7051

merged 3 commits into from
May 19, 2025

Conversation

IllianiBird
Copy link
Collaborator

Recent changes to Avionics#getStickerPrice prevent existing campaign saves from being loaded if that campaign has a unit that uses Avionics. Or, if the campaign has an Avionics part in their warehouse.

This is because unit is null both during loading and while a part is loose in the warehouse.

Added null protection to the method which resolves the issue.

@IllianiBird IllianiBird self-assigned this May 19, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 19, 2025 05:40
@IllianiBird IllianiBird added Bug Blocker Severity: Critical Issues described as critical as per the new issue form labels May 19, 2025
Scoppio
Scoppio approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator
@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the part effectively zero cost lol

@Scoppio Scoppio merged commit 91ff2d5 into MegaMek:master May 19, 2025
3 checks passed
@codecov Codecov
Copy link
codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (103c845) to head (e72d548).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/campaign/parts/Avionics.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7051      +/-   ##
============================================
- Coverage     12.03%   12.03%   -0.01%     
- Complexity     6888     6891       +3     
============================================
  Files          1103     1103              
  Lines        142266   142282      +16     
  Branches      21988    21991       +3     
============================================
+ Hits          17122    17123       +1     
- Misses       123310   123324      +14     
- Partials       1834     1835       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiBird IllianiBird deleted the fixedAvionicsLoading branch June 7, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scoppio Scoppio Scoppio approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Blocker Bug Severity: Critical Issues described as critical as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @Scoppio
0