8000 Fix: Stopped Higher Administration Skill Making Reinforcement Attempts Harder by IllianiBird · Pull Request #7053 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Fix: Stopped Higher Administration Skill Making Reinforcement Attempts Harder #7053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Fix: Stopped Higher Administration Skill Making Reinforcement Attempts Harder #7053

merged 1 commit into from
May 19, 2025

Conversation

IllianiBird
Copy link
Collaborator

A small polarity error in target number calculations.

@IllianiBird IllianiBird self-assigned this May 19, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner May 19, 2025 17:29
@IllianiBird IllianiBird added Bug StratCon Bugs relating strictly to StratCon Severity: Medium Issues described as medium severity as per the new issue form labels May 19, 2025
@IllianiBird IllianiBird merged commit b9446d9 into MegaMek:master May 19, 2025
3 checks passed
@codecov Codecov
Copy link
codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 12.03%. Comparing base (e72d548) to head (51fab80).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../mekhq/campaign/stratcon/StratconRulesManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #7053   +/-   ##
=========================================
  Coverage     12.03%   12.03%           
+ Complexity     6891     6890    -1     
=========================================
  Files          1103     1103           
  Lines        142282   142282           
  Branches      21991    21991           
=========================================
+ Hits          17123    17126    +3     
+ Misses       123324   123321    -3     
  Partials       1835     1835

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IllianiBird IllianiBird

Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form StratCon Bugs relating strictly to StratCon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IllianiBird
0