Improvement: Separated Reputation-Related Campaign Options Into Their Own Tab #7062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7062 +/- ##
============================================
- Coverage 12.42% 12.42% -0.01%
Complexity 7243 7243
============================================
Files 1117 1118 +1
Lines 144014 144066 +52
Branches 22166 22166
============================================
+ Hits 17898 17902 +4
- Misses 124279 124325 +46
- Partials 1837 1839 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR extracts reputation-related settings from the General tab into a new “Systems” tab, cleans up the General tab accordingly, and updates the recommended reading panel to include A Time Of War (ATOW).
- Introduces
SystemsTabclass to host reputation options - Removes reputation controls from
GeneralTaband wires upSystemsTabinCampaignOptionsPane - Consolidates reading list entries into a single HTML label and adds ATOW
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/campaignOptions/contents/SystemsTab.java | New tab class containing reputation controls |
| MekHQ/src/mekhq/gui/campaignOptions/contents/GeneralTab.java | Removed reputation code and added ATOW reading entry |
| MekHQ/src/mekhq/gui/campaignOptions/CampaignOptionsPane.java | Instantiates and wires in SystemsTab |
| MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties | Moved reputation keys under “Systems Tab” and updated reading list |
MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties
Outdated
Show resolved
Hide resolved
|
Conflicts. but looks good. |
# Conflicts: # MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7083
The title pretty much says everything. With the upcoming Faction Standing system it made sense to create a new tab to house that sort of thing. It also has the added benefit of cleaning up the General tab.
I also took the opportunity to add ATOW to the recommended reading list.
For the curious Reputation options can now be found here:
Operations -> Systems -> Reputation