8000 Fix: Fixed a Couple of Minor Issues With News Dialogs by IllianiBird · Pull Request #7281 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: Fixed a Couple of Minor Issues With News Dialogs #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Fix: Fixed a Couple of Minor Issues With News Dialogs #7281

merged 1 commit into from
Jul 1, 2025

Conversation

IllianiBird
Copy link
Collaborator

Nothing particularly exciting. Just a typo and a change to utilize a new default image.

@IllianiBird IllianiBird self-assigned this Jun 29, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner June 29, 2025 04:32
@IllianiBird IllianiBird added Bug Severity: Low Issues described as low severity as per the new issue form labels Jun 29, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.75%. Comparing base (790bd97) to head (fbb4530).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/dialog/NewsDialog.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #7281      +/-   ##
============================================
- Coverage     12.76%   12.75%   -0.01%     
+ Complexity     7536     7534       -2     
============================================
  Files          1148     1148              
  Lines        147785   147786       +1     
  Branches      22586    22586              
============================================
- Hits          18858    18849       -9     
- Misses       126901   126914      +13     
+ Partials       2026     2023       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sleet01
Sleet01 approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator
@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiBird IllianiBird merged commit e61a3b1 into MegaMek:master Jul 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees

@IllianiBird IllianiBird

Labels
Bug Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IllianiBird @Sleet01
0