Improvement: Updated Faction Starting Location Logic for Mercenary and Pirate Campaigns #7301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Pirate Campaigns
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7301 +/- ##
============================================
- Coverage 12.70% 12.68% -0.02%
Complexity 7575 7575
============================================
Files 1166 1171 +5
Lines 149038 149172 +134
Branches 22867 22890 +23
============================================
- Hits 18939 18929 -10
- Misses 128067 128213 +146
+ Partials 2032 2030 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the 50.07 dev cycle I introduced some logic to allow pirate campaigns to start on any playable faction's capital. The intent was for this to introduce a degree of randomness to a play start. However, I really wasn't happy with the code and it didn't really work as I intended.
So I went ahead and updated the logic, improved it for robustness and extended the random start logic to mercenary campaigns.
The logic is thus:
Combined with the new faction standing system, this should help give individual campaigns more character. Especially mercenary campaigns, as it means campaigns will now start embedded in nations other than the Lyran Commonwealth.