8000 Remove restriction limiting generated/dynamic Scenarios to the current Campaign Week by sldfgunslinger2766 · Pull Request #3453 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove restriction limiting generated/dynamic Scenarios to the current Campaign Week #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

sldfgunslinger2766
Copy link
Contributor

This PR will remove the restriction on confining generated/dynamic Scenarios to the current Campaign Week.

@codecov
Copy link
codecov bot commented Sep 9, 2022

Codecov Report

Merging #3453 (978937f) into master (93c4d0b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #3453   +/-   ##
=========================================
  Coverage     10.95%   10.95%           
  Complexity     5477     5477           
=========================================
  Files           826      826           
  Lines        113180   113172    -8     
  Branches      17113    17111    -2     
=========================================
  Hits          12395    12395           
+ Misses        99570    99562    -8     
  Partials       1215     1215           
Impacted Files Coverage Δ
.../src/mekhq/gui/dialog/CustomizeScenarioDialog.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member
@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a weird and unnecessarily cumbersome restriction, so I'm happy to see it go. We'll merge it after the upcoming bugfix release gets put out.

@NickAragua NickAragua merged commit fa9570d into MegaMek:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0