8000 Adding Faction Data Validation to Campaign Options Pane by Windchild292 · Pull Request #3466 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adding Faction Data Validation to Campaign Options Pane #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Windchild292
Copy link
Contributor

I have no ability to test this, but have known the first was technically possible. The second one is just a safety check, as that will cause problems in future if it is set to blank.

@Windchild292 Windchild292 self-assigned this Sep 28, 2022
@codecov
Copy link
codecov bot commented Sep 28, 2022

Codecov Report

Base: 10.95% // Head: 10.95% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a5d22b9) compared to base (d86a4d0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3466   +/-   ##
=========================================
  Coverage     10.95%   10.95%           
  Complexity     5477     5477           
=========================================
  Files           826      827    +1     
  Lines        113172   113160   -12     
  Branches      17111    17115    +4     
=========================================
  Hits          12395    12395           
+ Misses        99562    99550   -12     
  Partials       1215     1215           
Impacted Files Coverage Δ
...gui/baseComponents/AbstractMHQScrollablePanel.java 0.00% <ø> (ø)
.../gui/baseComponents/DefaultMHQScrollablePanel.java 0.00% <0.00%> (ø)
...src/mekhq/gui/baseComponents/JScrollablePanel.java 0.00% <ø> (ø)
...HQ/src/mekhq/gui/dialog/CustomizePersonDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/GMToolsDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/panes/CampaignOptionsPane.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/panes/CampaignPresetPane.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/panes/RankSystemsPane.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit d5505f4 into MegaMek:master Nov 15, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_CampaignOptionsFactionValidation branch November 15, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0