Fixes issue where training ammo was affected by the parts cost multiplier #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lier for use parts.
Codecov ReportBase: 10.95% // Head: 10.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3486 +/- ##
=========================================
Coverage 10.95% 10.95%
Complexity 5477 5477
=========================================
Files 827 827
Lines 113147 113147
Branches 17111 17111
=========================================
Hits 12395 12395
Misses 99537 99537
Partials 1215 1215
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NickAragua
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was caused by the PR adding code for Joda Money. I did find another bug when calculating the cost of SRM 6 ammo but I do not know the cause or reason. It uses getStickerPrice() as does other parts of the HQ code, but only in this instance (and when using the replaced function) SRM6 ammo costs 28,929 instead of the typical 27,000. It does not affect other SRM ammo and those show up correctly.