8000 Data Loading: Don't Override the Selected Date by Windchild292 · Pull Request #3538 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Data Loading: Don't Override the Selected Date #3538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

Data Loading: Don't Override the Selected Date #3538

merged 1 commit into from
Dec 20, 2022

Conversation

Windchild292
Copy link
Contributor

Found this while working on #3533

@Windchild292 Windchild292 self-assigned this Dec 17, 2022
@codecov
Copy link
codecov bot commented Dec 17, 2022

Codecov Report

Base: 10.97% // Head: 10.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (da825e7) compared to base (de727b8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3538      +/-   ##
============================================
- Coverage     10.97%   10.97%   -0.01%     
  Complexity     5507     5507              
============================================
  Files           827      827              
  Lines        113212   113249      +37     
  Branches      17103    17108       +5     
============================================
  Hits          12424    12424              
- Misses        99564    99601      +37     
  Partials       1224     1224
Impacted Files Coverage Δ
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/panes/CampaignOptionsPane.java 0.00% <ø> (ø)
...HQ/src/mekhq/gui/dialog/CampaignOptionsDialog.java 0.00% <0.00%> (ø)
.../src/mekhq/gui/dialog/CompanyGenerationDialog.java 0.00% <0.00%> (ø)
...c/mekhq/gui/dialog/iconDialogs/UnitIconDialog.java 0.00% <0.00%> (ø)
...gui/dialog/iconDialogs/LayeredForceIconDialog.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SJuliez
SJuliez approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member
@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If presets were things like "Pirate Campaign in the 3080ies" a date would make sense. But I suppose presets are more a bunch of technical settings here.

@Windchild292
94AB Copy link
Contributor Author

They still contain the date, it is just used earlier in the flow where a user can select and modify the date. This was overriding the user's input date.

@Windchild292 Windchild292 merged commit 2b1baa3 into MegaMek:master Dec 20, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_DataLoadingDateNotSetting branch December 20, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

Assignees

@Windchild292 Windchild292

Labels
Bug GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Windchild292 @SJuliez
0