8000 Yearly Retirement Nag Now Follows Campaign Options by Windchild292 · Pull Request #3557 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Yearly Retirement Nag Now Follows Campaign Options #3557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

Yearly Retirement Nag Now Follows Campaign Options #3557

merged 1 commit into from
Feb 7, 2023

Conversation

Windchild292
Copy link
Contributor

This fixes a dumb mistake I made and adds fixmes for the missing localization.

@Windchild292 Windchild292 added Bug AtB Personnel Personnel-related Issues labels Jan 9, 2023
@Windchild292 Windchild292 self-assigned this Jan 9, 2023
@codecov
Copy link
codecov bot commented Jan 9, 2023 •
edited
Loading

Codecov Report

Base: 10.96% // Head: 10.96% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (332b06c) compared to base (f8619dd).
Patch coverage: 4.34% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3557      +/-   ##
============================================
- Coverage     10.96%   10.96%   -0.01%     
- Complexity     5507     5508       +1     
============================================
  Files           828      829       +1     
  Lines        113261   113274      +13     
  Branches      17109    17113       +4     
============================================
+ Hits          12424    12425       +1     
- Misses        99613    99626      +13     
+ Partials       1224     1223       -1
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/Campaign.java 6.53% <0.00%> (+<0.01%) ⬆️
MekHQ/src/mekhq/campaign/io/CampaignXmlParser.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/personnel/Skill.java 0.00% <0.00%> (ø)
...Q/src/mekhq/gui/adapter/UnitTableMouseAdapter.java 0.00% <0.00%> (ø)
...HQ/src/mekhq/io/migration/GameOptionsMigrator.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/campaign/personnel/SkillType.java 61.28% <20.00%> (-0.59%) ⬇️
...ekHQ/src/mekhq/campaign/personnel/SkillPrereq.java 28.57% <0.00%> (+1.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit 6784f22 into MegaMek:master Feb 7, 2023
@Windchild292 Windchild292 deleted the dev_Windchild_YearlyRetirementNag branch February 7, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhancock rjhancock rjhancock approved these changes

Assignees

@Windchild292 Windchild292

Labels
AtB Bug Personnel Personnel-related Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Windchild292 @rjhancock
0