8000 Swap Frame Uses to JFrame by Windchild292 · Pull Request #3591 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Swap Frame Uses to JFrame #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Windchild292
Copy link
Contributor

This is a bug because Frame uses sometimes fail to call all of the accessibility methods that JFrame uses will catch.

@Windchild292 Windchild292 added Bug Accessibility Work dealing with improving the accessibility of the application GUI Refactoring labels Jan 30, 2023
@Windchild292 Windchild292 self-assigned this Jan 30, 2023
@codecov
Copy link
codecov bot commented Jan 30, 2023

Codecov Report

Base: 10.96% // Head: 10.96% // No change to project coverage 👍

Coverage data is based on head (3d2572a) compared to base (8e026af).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3591   +/-   ##
=========================================
  Coverage     10.96%   10.96%           
  Complexity     5508     5508           
=========================================
  Files           829      829           
  Lines        113362   113362           
  Branches      17126    17126           
=========================================
  Hits          12426    12426           
  Misses        99713    99713           
  Partials       1223     1223           
Impacted Files Coverage Δ
MekHQ/src/mekhq/MekHQ.java 3.82% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/AddFundsDialog.java 0.00% <0.00%> (ø)
...kHQ/src/mekhq/gui/dialog/ChooseFactionsDialog.java 0.00% <0.00%> (ø)
...kHQ/src/mekhq/gui/dialog/ContractMarketDialog.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/EditAssetDialog.java 0.00% <0.00%> (ø)
...HQ/src/mekhq/gui/dialog/EditInjuryEntryDialog.java 0.00% <0.00%> (ø)
.../src/mekhq/gui/dialog/EditPersonnelHitsDialog.java 0.00% <0.00%> (ø)
.../mekhq/gui/dialog/EditPersonnelInjuriesDialog.java 0.00% <0.00%> (ø)
...HQ/src/mekhq/gui/dialog/EditSkillPrereqDialog.java 0.00% <0.00%> (ø)
.../src/mekhq/gui/dialog/HireBulkPersonnelDialog.java 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Windchild292 Windchild292 merged commit 00a0492 into MegaMek:master Feb 7, 2023
@Windchild292 Windchild292 deleted the dev_Windchild_FrameSwapover branch February 7, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Work dealing with improving the accessibility of the application Bug GUI Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0