8000 3605: News Properly Shows in Advance Days Dialog by Windchild292 · Pull Request #3615 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

3605: News Properly Shows in Advance Days Dialog #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2023
Merged

3605: News Properly Shows in Advance Days Dialog #3615

merged 2 commits into from
Feb 26, 2023

Conversation

Windchild292
Copy link
Contributor

This fixes #3605

@Windchild292 Windchild292 self-assigned this Feb 26, 2023
@codecov
Copy link
codecov bot commented Feb 26, 2023

Codecov Report

Base: 10.67% // Head: 10.67% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (86649c7) compared to base (fd741ce).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3615      +/-   ##
============================================
- Coverage     10.67%   10.67%   -0.01%     
  Complexity     5472     5472              
============================================
  Files           830      830              
  Lines        113345   113364      +19     
  Branches      17096    17099       +3     
============================================
  Hits          12099    12099              
- Misses       100038   100057      +19     
  Partials       1208     1208
Impacted Files Coverage Δ
MekHQ/src/mekhq/campaign/Campaign.java 6.46% <0.00%> (-0.01%) ⬇️
MekHQ/src/mekhq/gui/CommandCenterTab.java 0.00% <0.00%> (ø)
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% <0.00%> (ø)
MekHQ/src/mekhq/gui/dialog/AdvanceDaysDialog.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

SJuliez
SJuliez approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member
@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I don't understand the bug nor the solution. It looks like all reports would be added twice. (But obviously the reports werent added at all before) But then, I don't know where currentReportHTML is ever filled, it's only emptied in newDay(), so where does the report from line 298 come from? I know too little of this code :(

@Windchild292 Windchild292 merged commit 17cc514 into MegaMek:master Feb 26, 2023
@Windchild292 Windchild292 deleted the dev_Windchild_3605 branch February 26, 2023 19:16
@Windchild292
Copy link
Contributor Author

I don't understand how reports are coded either, but this works so I'm fine with it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjhancock rjhancock rjhancock approved these changes

@SJuliez SJuliez SJuliez approved these changes

Assignees

@Windchild292 Windchild292

Labels
Blocker GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow news blurbs links to appear when using "Advance Multiple Days"
3 participants
@Windchild292 @rjhancock @SJuliez
0