Closing opening comment in eras.xml #3831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3831 +/- ##
============================================
- Coverage 10.63% 10.62% -0.01%
Complexity 5472 5472
============================================
Files 834 834
Lines 113830 113860 +30
Branches 17197 17197
============================================
- Hits 12101 12097 -4
- Misses 100522 100555 +33
- Partials 1207 1208 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MekHQ stopped being able to run, crashing whenever I tried to start a new campaign, or load an existing one. After some digging, I found that eras.xml was missing the closing tag on the opening comment.
Adding that, I can now start and load campaigns.
Interestingly, it seems to have been missing for quite some time, so potentially the xml parser we use got an update, or got set more strict recently. Not sure.