8000 fix: mesh.frag no spec color when roughness == 0 by deepkolos · Pull Request #107 · BoomingTech/Piccolo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: mesh.frag no spec color when roughness == 0 #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

deepkolos
Copy link

i found render error when i study pbr from mesh.frag

https://github.com/deepkolos/webgl-pbr-demo

there no spec color when roughness == 0

z41jds7qMc

THREEJS's output

image

@hyv1001 hyv1001 merged commit d508c8a into BoomingTech:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0