Nyaml2nxdl bug #78
Merged
Nyaml2nxdl bug #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbrock
approved these changes
Mar 22, 2023
sanbrock
previously requested changes
Mar 22, 2023
The problem is that the master branch is currently failing with the exact same error we have here. We need to merge #75 first and then rebase here to fix the ci/cd |
7147225 to
0f10cd2
Compare
added 23 commits
March 23, 2023 16:26
['\0', '\a', '\b', '\t', '\t',
'\n', '\v', '\f', '\r', '\e',
' ', '"', '\', '/', '\N',
'\_', '\L', '\P']
indide any doboule codes.
changes: All doc strings are in the next lines without any double codes.
['\0', '\a', '\b', '\t', '\t',
'\n', '\v', '\f', '\r', '\e',
' ', '"', '\', '/', '\N',
'\_', '\L', '\P']
indide any doboule codes.
changes: All doc strings are in the next lines without any double codes.
…traGroups','ignoreExtraFields',
'ignoreExtraAttributes']
Adding some TODO for making code clean and more readable.
…sted_handle' instead making the code real recursive.
fixing attributes of attributes and including recursive_build for xml_hadle_attribute in yaml->nxdl
…rntly working fine.
…rntly working fine.
append link functionality with backward converter
…file nyaml2nxdl_helper.py
added 17 commits
March 23, 2023 16:26
… to pass to yaml library.
… note'. Use example to explain: ~/Nomad-FAIRmat/NomadGH/GH_Clone/nomad-parser-nexus/tests/data/nyaml2nxdl/Ref_NXentry.nxdl.xml
… index and value'.
… for searching name with NX or group with NX
…me level, without regarding under indentation or overindentation.
0f10cd2 to
af0a667
Compare
8000
Pull Request Test Coverage Report for Build 4518429705
💛 - Coveralls |
andreaa93
approved these changes
Mar 23, 2023
domna
approved these changes
Mar 27, 2023
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seams work perfectly still not taking care of comments in forward and backward convert.
For comments I have another branch
nyaml2nxdl_comment_conversion:Self Comments for dev:
TODO: Needs to track of parent yaml node such as NX-fields, NX-attributes and NX-Group etc