8000 Nexus read by RubelMozumder · Pull Request #90 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Nexus read #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 20, 2023
Merged

Nexus read #90

merged 17 commits into from
Apr 20, 2023

Conversation

RubelMozumder
Copy link
Collaborator

@shabihsherjeel, After you are done with your code you can merge this branch.

@sherjeelshabih
Copy link
Collaborator

@RubelMozumder I have removed my changes as there are some readers that need to be fixed with it. I'll make another branch for that. My changes aren't a blocker for this MR anymore.

@sherjeelshabih sherjeelshabih mentioned this pull request Apr 18, 2023
Merged
RubelMozumder added 2 commits April 18, 2023 16:14
Including -d and -c options. This is working perfectly.
d7f06e4 
Passing test for c option.

passing test, pylint, pydocstley and mypa
Including Reference file for c-option test.
bb17478
@RubelMozumder RubelMozumder requested review from sherjeelshabih and sanbrock and removed request for sherjeelshabih April 18, 2023 19:32
sherjeelshabih
sherjeelshabih requested changes Apr 19, 2023
View reviewed changes
sanbrock
sanbrock requested changes Apr 19, 2023
View reviewed changes
@RubelMozumder RubelMozumder requested review from sherjeelshabih and removed request for sherjeelshabih April 19, 2023 19:33
@coveralls
Copy link
coveralls commented Apr 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4753576611

  • 109 of 118 (92.37%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 56.404%
Changes Missing Coverage Covered Lines Changed/Added Lines %
nexusutils/nexus/nexus.py 71 80 88.75%
Files with Coverage Reduction New Missed Lines %
nexusutils/nexus/nexus.py 1 74.17%
Totals Coverage Status
Change from base Build 4732955189: 0.5%
Covered Lines: 4232
Relevant Lines: 7503
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4747084968

  • 108 of 117 (92.31%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 55.979%
Changes Missing Coverage Covered Lines Changed/Added Lines %
nexusutils/nexus/nexus.py 70 79 88.61%
Files with Coverage Reduction New Missed Lines %
nexusutils/nexus/nexus.py 1 74.17%
Totals Coverage Status
Change from base Build 4732955189: 0.08%
Covered Lines: 4035
Relevant Lines: 7208
💛 - Coveralls

@sanbrock
Copy link
Collaborator

As I see, the forced-pushes from Rubel took away the modifications from Sherjeel and me, so I will bring those changes back.

sanbrock
sanbrock approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator
@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanbrock sanbrock merged commit 6d431b8 into master Apr 20, 2023
@RubelMozumder RubelMozumder deleted the nexus_read branch April 21, 2023 08:26
RubelMozumder added a commit that referenced this pull request Jun 28, 2023
@RubelMozumder @sanbrock @sherjeelshabih
Nexus read (#90)
4fcffc4 
* -d for documentation is done. -c for concept is not done

* support for name specialising inheritance

* added testcase

* Added a new template generation using inheritance

* Including -d and -c options. This is working perfectly.

Passing test for c option.

passing test, pylint, pydocstley and mypa

* Including Reference file for c-option test.

* fixing pytest, pylint and so on

* Linking the REAMDME file path according to their file path.

* fix for nameTyoe check

* resolving changes as requested.

* Fixing error from lack of zero in decimal places.

* revert conflict resolution and reset to of Rubel

* remove Sherjeels code from this branch

* linting

---------

Co-authored-by: RubelMozumder <rubelmozumder@outlook.com>
Co-authored-by: Sandor Brockhauser <sandor.brockhauser@xfel.eu>
Co-authored-by: Sherjeel Shabih <shabihsherjeel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherjeelshabih sherjeelshabih sherjeelshabih requested changes

@sanbrock sanbrock sanbrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RubelMozumder @sherjeelshabih @coveralls @sanbrock
0