8000 Inheritance check dataconverter by sherjeelshabih · Pull Request #91 · FAIRmat-NFDI/pynxtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Inheritance check dataconverter #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 24, 2023
Merged

Inheritance check dataconverter #91

merged 12 commits into from
Apr 24, 2023

Conversation

sherjeelshabih
Copy link
Collaborator

Depends on #90 for some CI tests. But this branch has reader tests failing. These can be handled here. Once #90 has been merged to master, I'll pull in the changes.

@sherjeelshabih sherjeelshabih force-pushed the inheritance_check_dataconverter branch from c628309 to 6fd5419 Compare April 19, 2023 07:29
@sherjeelshabih sherjeelshabih marked this pull request as ready for review April 19, 2023 16:21
@sherjeelshabih sherjeelshabih marked this pull request as draft April 19, 2023 16:21
@sherjeelshabih sherjeelshabih marked this pull request as ready for review April 19, 2023 16:58
@coveralls
Copy link
coveralls commented Apr 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4783829988

  • 63 of 63 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 58.259%
Totals Coverage Status
Change from base Build 4766278227: 0.3%
Covered Lines: 4751
Relevant Lines: 8155
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4746172977

  • 171 of 179 (95.53%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 56.717%
Changes Missing Coverage Covered Lines Changed/Added Lines %
nexusutils/nexus/nexus.py 70 78 89.74%
Files with Coverage Reduction New Missed Lines %
nexusutils/nexus/nexus.py 1 74.26%
Totals Coverage Status
Change from base Build 4732955189: 0.8%
Covered Lines: 4285
Relevant Lines: 7555
💛 - Coveralls

domna
domna approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator
@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did not review it in super much detail as I'm also not too involved in the internal workings around this part, but regarding the passing tests and structure of this it seems good to me.

RubelMozumder and others added 12 commits April 24, 2023 09:18
@sherjeelshabih sherjeelshabih force-pushed the inheritance_check_dataconverter branch from 44a2893 to d316b5f Compare April 24, 2023 07:53
@sherjeelshabih sherjeelshabih merged commit 9b47a26 into master Apr 24, 2023
@sherjeelshabih sherjeelshabih deleted the inheritance_check_dataconverter branch April 24, 2023 07:58
RubelMozumder pushed a commit that referenced this pull request Jun 28, 2023
@sherjeelshabih
Merge pull request #91 from nomad-coe/inheritance_check_dataconverter
a8757ce 
Inheritance check dataconverter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

@RubelMozumder RubelMozumder Awaiting requested review from RubelMozumder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherjeelshabih @coveralls @domna
0