update-north-markus #141
Merged
update-north-markus #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m example in update-north-markus nomad FAIR
…loyment for atom probe groups like Leoben and others
…e and functionality, apm: started refactoring loading of ELN data to use em_nion concept of mapping tables instead of custom, hardcoded many section-specific functions, apm: Added support for decoupling metadata from ELN and a deployment-specific configuration file, whereby users of specific OASIS do no longer need to expose all metadata in the ELN template but can instead use the deployment-specific configuration file to inject e.g. not changing metadata like versions, or specific details about instruments directly from the configuration yaml file, thereby the amount of retyping in ELNs can be reduced, an additional potential benefit of this design is that ELNs may appear now less complex for end users which was a point raised by Lorenz Romaner from Leoben
…pport for dual-laser setup of LEAP6000 instrument, initial code styling, linting round, next steps i) implement reading of composition from ELN, ii) test
…and tested the apm dataconverter, modified standalone ipynb, apm reader is fully functional again, next step, check that em_nion reader remains functional after the refactoring of the ELN utility functions and use the same mapping refactoring for em_spctrscpy and em_om reader
…us-north 5ff040d to integrated latest changes of Leoben oasis for atom probe and start the summer break implementation to integrate community feedback for EBSD, EDS, user feedback from Annette Trunschkes group at the FHI"
…lts via the fairmat_2023_pullback branch
…related h5web to run standalone examples
…s are also affected as many fields in base classes were removed in during the code camp, please inspect @domna, updated dev-requirements and, fixed linting
… Ref_nexus_test, this commit might therefore need to be reverted
sanbrock
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge features developed within June (partially during sprint 15) for creating deployable apm-specific OASES in Leoben and Sydney to master so that these can appear in a new nomad oasis deployment