Fix objective filter not reacting dynamically #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com>
Merged
Electroid
approved these changes
Sep 2, 2022
Samuel-Roach
pushed a commit
to Samuel-Roach/PGM
that referenced
this pull request
Sep 3, 2022
Signed-off-by: Pablete1234 <pabloherrerapalacio@gmail.com> Signed-off-by: Samuel Roach <samuelroach.2000@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective filter when wrapped around a TeamFilterAdapter does no longer react dynamically because they did not rely the getRelevantEvents().
Additionally, when using an objective filter without an any=true on monument modes, those will throw an exception when trying to activate, as the filterable was not correct. While a better fix should be done down the line to properly manage those at parse time, for the time being the map will fail to load and report it on console instead, which is better than it just not working reliably