fix(flags): pass in the correct hashes. #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR fixes the feature flag rollout hashing algorithm by switching from SHA256 to SHA1 hashes for token validation, ensuring consistent behavior with the existing is_token_in_rollout implementation.
- Updated
INCLUDED_HASHESandEXCLUDED_HASHESsets inclient.pywith correct SHA1 hashes instead of SHA256 - Added test case in
test_client.pyto verify PostHog API key is correctly included in rollout calculations - Fixed potential issue where tokens could be incorrectly included/excluded from rollouts due to hash mismatch
- Ensures backward compatibility since
is_token_in_rolloutwas already using SHA1
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
raquelmsmith
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did the flag hashing algorithm incorrectly and passed in SHA256 instead of sha1 hashes... stupid script.
This works and I confirmed with more unit tests.