8000 fix(flags): pass in the correct hashes. by dmarticus · Pull Request #221 · PostHog/posthog-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(flags): pass in the correct hashes. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

fix(flags): pass in the correct hashes. #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fec30e
shoot
dmarticus Apr 15, 2025
052b3df
cut customer token
dmarticus Apr 15, 2025
fb8da03
bump version
dmarticus Apr 15, 2025
a8a8dc3
dump posthog api from excluded
dmarticus Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.24.3 – 2025-04-15

1. Fix hash inclusion/exclusion for flag rollout

## 3.24.2 – 2025-04-15

1. Roll out new /flags endpoint to 10% of /decide traffic
Expand Down
124 changes: 62 additions & 62 deletions posthog/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,71 +54,71 @@

# TODO: Get rid of these when you're done rolling out `/flags` to all customers
ROLLOUT_PERCENTAGE = 0.1
INCLUDED_HASHES = set({"c4c6803067869081a8c4686780f32de979ade862c6af9ff9ebe5b7161e18362f"}) # this is PostHog's API key
INCLUDED_HASHES = set({"bc94e67150c97dbcbf52549d50a7b80814841dbf"}) # this is PostHog's API key
# Explicitly excluding all the API tokens associated with the top 10 customers; we'll get to them soon, but don't want to rollout to them just yet
EXCLUDED_HASHES = set(
{
"5fbb169efa185c2a78d43574b01b56c66d7bb594b310f72702e1f167e4e283a9",
"374be8e6556709787d472e276ebe3c46c0ab4b868ec99f4c96168a44df8307df",
"6c8a2d5e9dbd4c71854aebca3026fe50045b05e19a16780dccea5439625ee1b4",
"0f1fa079412bb39b5fce8d96af3539925ede61cbc561ffcd38e27c8e8ae64edb",
"e3bdce3350e62638ffbf79872c2fd69ef6cbbd35712d9faf735f874cf77ccbfc",
"f96fe01cdf22f1ec75bc7c897e9605e6431fb5d8f6a8bb9d0e8fce2b0a1384a6",
"6859b51ac773ea98e146bae47e98759f97ec64c253b9c0524ab56793cc5b6c75",
"06b28c04e490ce1c9c017396b8b8e16fce1176a8b5de131a99d9af4df1d0fbc9",
"d9c0afa45a34c9f3c1e615bfa77394b79ad7b434ea46856e3503445d5974d640",
"320eb50509e2c58a50d80fac848ee0b86290c848a173a0402abdbb760b794595",
"7380abb65605420dd6e61534c8eecaa6f14d25a6f90ec2edba811f7383123ded",
"3182881fa027d1c8e4eea108df66dcb0387e375d1e4b551c3a3579fdb1e696d1",
"d685aeb7d02ec757c4cbe591050a168d34be2f5305d9071d9695ed773057ef16",
"875ab92bec4da51cf229145565364e98347fafaa2316a4a8e20f5d852bc95aed",
"4a0d726e4b56d6f6d0407faf5396847146084bbabd042ca0dedba2873d8f9236",
"a9dc6415c1ccd1874ed1cd303e3d5bf92ddb17ac2af968abed14a51dfb0c53be",
"5f10a055c9e379869a159306b1d7242fec25584ce895f677f82a13133741c7f1",
"e3e7608bbda7c15bf82fd7e2945ca74052f8b99e2090962318b6ef983c0ddb16",
"7f0cbd50e11b475f6c2ed50e620c473e4bfc8df1f4c5174b49ecee1fcec6853e",
"03004fb2209e6e4186c4364c71e5abc9cf272caf83cf58fb538c42684fd42fb0",
"8721e8bf608c5eb4d74eeaf26fe588b4e5414742e0494ca7e67a89e1a297332b",
"ac0d5c7daee8d2f89d5b3861fba0b9a0e560b0eb6944e974f37cdc52274f2d1f",
"6581d65cf0c4c536122beb5d581ba2b128ed44b7528c07d4ec7837ea33d0cffe",
"d0c2d4e122ecd4520af7bac133b09fde357622f20aa5a0f7a9328d25c9e9f28e",
"d09de64bec03c750493b0771c9f2731204bc9a5f0479628848803e2ccded9aca",
"a9f483f0cdc028a5e05d03d7ab683738f09a940c0173d9e6b004fbe85738a1f5",
"2ffb5817a9fc465b9bb37b9112393cc1a274185f7f18618192421b7511b98830",
"a6785a722fdb0f975a1a30302f8312709ae069358c901c609f4898a9ae14bdf2",
"3d9ba35cab44358cf47c867f48c95f75b9ad54ca5407ed19576da55a085d3a8f",
"ff59d2907ecb66f4d4a1705435460124a390d8cf7762dc7860d4b4171f832976",
"aac9e8036d3e0efed49cd5fbea19ea8354c4e1dfc95a1585300c5178189e5bac",
"1e7fa74813f733e35ea820f8272c6562b4b0c70429f1b549605cc9e8016f632e",
"2cb74b224cb20b8e5a5a52f3fe5ca62672e5c77ce7f30223698bb4d4abff2293",
"17a90589bfe29f40f826e2df4753c0bce17a05f4c04b9a0924304e7418aba9e8",
"0925e4c5bc65ced02c65aa3afba5eaa98aed288d193f719a8fbaebafdeafc1ce",
"a0308973730b505f1d6af7cd2f39c69bd86ea2a35b9d27118910e1c58d9a6a1a",
"c780092461636d6d62179723f03cbfe4a7b5808a6b46de749d8b32c3384f1e74",
"65d6083548c27387f9381ff2aa37581a41ba1d5e6162afdc18cf8130be528052",
"e2241631d1211e15688735ec6d9f56b4839e65d2095f278630c884bd49f00be8",
"f2d9e1c10371912c32e9eba18f348782345ff70d383ae8b38bc9e6b12c7841e7",
"57411b20e1c406ac4339718287b3eaa83635291fb593c9a4068dd08ec1d03692",
"06e91ecd6b2a9a02234951ab3a5a95aeb84ef34499a5001629aaa13d907ba1dc",
"4d2f47e99000f6820307e525fcf972421335a86f39b6ada1c93d67410520af49",
"538d3b1415c3feccbe68d59b5ad9ed35aa418fc64658ff603855494abf75f647",
"68b11387ac9f805bdbea486b9d3e0724856180646f2b12617a81174d5c27833c",
"a74797287c3d29f92fc729c2a8b3f17638cb273388e12cb8ffd972bcfbcdfdb8",
"b53d2b6551ebd8d68321dbd2727a299b1d23ff15853be02fffb0c54f1f0e1349",
"abad9dc57c9cb9a244b89b11f0a9123baf924a6908443dd8527cf6b411bbb33a",
"d17b55c7d72052d76d76a039e1ceb613d443401d30eae91ac903a07d5ee0d2d2",
"274a08018c6e4609dedc37e31aea589c527cd7b93242d305591c3f5313408ee8",
"75ed9cca6d877ea218647d6021b89c5959156eed2ce4ccad29d4e497d9cd0119",
"4862317bab4b4efc876a810b92a6841bcf6ba69ac7aa7ff792358862528e7fa8",
"f0498fff4318e52729573a8bf451d7b978c5242af51ec8b1699798090bc00d32",
"a6a3435402f66a94eefd07b16297f6b4a61e26992e8ed7742de2e49d7ea71104",
"72d8ede07d3ef0fd8eb0cd7261d29f4f33b3554e06a726db151138a25a01b539",
"937c4aae120326c861eb3ec23371e029d3cea21f5849e4d52d75e47e06473e5c",
"e0138f35502faac574232bbbaab7ad769e2dcd449b596e32454368cb3cc035f9",
"084e32dc89830d7bb120492ed55cc543de0405c7ae3d0c16c8f64ab07c44506d",
"d59f0ce1670146019b2c77b56ff8faca6346adfcc93443712a613a89298e3fb9",
"b99bd54a29c2e9adc17527f9df539415a1c0a83293f72e3e0c8744c5677ea1a1",
"c252a61d3c19f58062ca9fe2b13dfe378bc11380705cec703d9d8d0a0e167995",
"03005596796f9ee626e9596b8062972cb6a556a0",
"05620a20b287e0d5cb1d4a0dd492797f36b952c5",
"0f95b5ca12878693c01c6420e727904f1737caa7",
"1212b6287a6e7e5ff6be5cb30ec563f35c2139d6",
"171ec1bb2caf762e06b1fde2e36a38c4638691a8",
"171faa9fc754b1aa42252a4eedb948b7c805d5cb",
"178ddde3f628fb0030321387acf939e4e6946d35",
"1790085d7e9aa136e8b73c180dd6a6060e2ef949",
"1895a3349c2371559c886f19ef1bf60617a934e0",
"1f01267d4f0295f88e8943bc963d816ee4abc84b",
"213df54990a34e62e3570b430f7ee36ec0928743",
"23d235537d988ab98ad259853eab02b07d828c2b",
"27135f7ae8f936222a5fcfcdc75c139b27dd3254",
"2817396d80fafc86c0816af8e73880f8b3e54320",
"29d3235e63db42056858ef04c6a5488c2a459eaa",
"2a76d9b5eb9307e540de9d516aa80f6cb5a0292f",
"2a92965a1344ab8a1f7dac2507e858f579a88ac2",
"2d5823818261512d616161de2bb8a161d48f1e35",
"32942f6a879dbfa8011cc68288c098e4a76e6cc0",
"3db6c17ab65827ceadf77d9a8462fabd94170ca6",
"4975b24f9ced9b2c06b604ddc9612f663f9452d5",
"497c7b017b13cd6cdbfe641c71f0dfb660a4c518",
"49c79e1dbce4a7b9394d6c14bf0421e04cecb445",
"4d63e1c5cd3a80972eac4e7526f03357ac538043",
"4da0f42a6f8f116822411152e5cda3c65ed2561f",
"4e494675ecd2b841784d6f29b658b38a0877a62e",
"4e852d8422130cec991eca2d6416dbe321d0a689",
"5120bfd92c9c6731074a89e4a82f49e947d34369",
"512cd72f9aa7ab11dfd012cc2e19394a020bd9a8",
"5b175d4064cc62f01118a2c6818c2c02fc8f27e1",
"5ba4bba3979e97d2c84df2aba394ca29c6c43187",
"639014946463614353ca640b268dc6592f62b652",
"643b9be9d50104e2b4ba94bc56688adba69c80fe",
"658f92992af9fc6a360143d72d93a36f63bbccb0",
"673a59c99739dfcee35202e428dd020b94866d52",
"67a9829b4997f5c6f3ab8173ad299f634adcfa53",
"6d686043e914ae8275df65e1ad890bd32a3b6fdd",
"6e4b5e1d649ad006d78f1f1617a9a0f35fc73078",
"6f1fc3a8fa9df54d00cbc1ef9ad5f24640589fd0",
"764e5fec2c7899cfee620fae8450fcc62cd72bf0",
"80ea6d6ed9a5895633c7bee7aba4323eeacdc90e",
"872e420156f583bc97351f3d83c02dae734a85df",
"8a24844cbeae31e74b4372964cdea74e99d9c0e2",
"975ae7330506d4583b000f96ad87abb41a0141ce",
"9e3d71378b340def3080e0a3a785a1b964cf43ef",
"9ede7b21365661331d024d92915de6e69749892b",
"a1ed1b4216ef4cec542c6b3b676507770be24ddc",
"a4f66a70a9647b3b89fc59f7642af8ffab073ba1",
"a7adb80be9e90948ab6bb726cc6e8e52694aec74",
"bca4b14ac8de49cccc02306c7bb6e5ae2acc0f72",
"bde5fe49f61e13629c5498d7428a7f6215e482a6",
"c54a7074c323aa7c5cb7b24bf826751b2a58f5d8",
"c552d20da0c87fb4ebe2da97c7f95c05eef2bca1",
"d7682f2d268f3064d433309af34f2935810989d2",
"d794ac43d8be26bf99f369ea79501eb774fe1b16",
"e0963e2552af77d46bb24d5b5806b5b456c64c5f",
"e6f14b2100cb0598925958b097ace82486037a25",
"e79ec399ad45f44a4295a5bb1322e2f14600ae39",
"eecf29f73f9c31009e5737a6c5ec3f87ec5b8ea6",
"f2c01f3cc770c7788257ee60910e2530f92eefc3",
"f7bbc58f4122b1e2812c0f1962c584cb404a1ac3",
}
)

Expand Down
4 changes: 4 additions & 0 deletions posthog/test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,3 +1336,7 @@ def test_token_rollout_calculation(self):

# Test that the token exclusion works correctly
self.assertFalse(is_token_in_rollout(token, percentage=1.0, excluded_hashes={token_hash}))

# Should work for other specific token hashes
# Include our API key
self.assertTrue(is_token_in_rollout("sTMFPsFhdP1Ssg", percentage=0.1, included_hashes=INCLUDED_HASHES))
2 changes: 1 addition & 1 deletion posthog/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION = "3.24.2"
VERSION = "3.24.3"

if __name__ == "__main__":
print(VERSION, end="") # noqa: T201
0