Fix i18n in subfolder environment #3772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not set, TAPi18n fetches `/tap-i18n` (maps to packages/rocketchat-lib/i18n directory). It should fetch `/subfolder/tap-i18n`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
If Rocket.Chat is running in subfolder environment(ex:
ROOT_URLis set tohttps://domain/chat), i18n is not working.In spite of
ROOT_URLis set tohttps://domain/chat, TAPi18n fetches/tap-i18n/*.json.It should fetch
/chat/tap-i18n/*.json.Then, 404 error has occurred.
(this screenshot is produced with
ROOT_URL=http://localhost:3000/test meteor)If
TAPi18n.conf.cdn_pathorTAPi18n.conf.i18n_files_routeis not set, TAPi18n fetches/tap-i18n(maps to packages/rocketchat-lib/i18n directory).Please review. Is this correct implementation?