8000 Bug: Some modules not using ROOT_URL with subfolder · Issue #973 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug: Some modules not using ROOT_URL with subfolder #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
68040 opened this issue Apr 3, 2017 · 13 comments
Closed

Bug: Some modules not using ROOT_URL with subfolder #973

68040 opened this issue Apr 3, 2017 · 13 comments
Labels
Bug

Comments

@68040
Copy link
68040 commented Apr 3, 2017 •
edited
Loading

Since update on v0.18 i can't set the language in the client anymore.

The selection opens, but when clicking on the menu entry, it doesn't select it. No checkmark and no language change.

Wekan 0.18. Release version. Manual install.
@xet7 xet7 added the Bug label Apr 3, 2017
@xet7
Copy link
Member
xet7 commented Apr 3, 2017

Moved to #962

@xet7 xet7 closed this as completed Apr 3, 2017
@68040 68040 mentioned this issue Apr 7, 2017
Closed
@xet7 xet7 reopened this Apr 7, 2017
@xet7
Copy link
Member
xet7 commented Apr 7, 2017

Moved back to here, and can be continued here.

@68040
Copy link
Author
68040 commented Apr 7, 2017 •
edited
Loading

This is one of the three resources i've found (/tap-i18n/, /cfs/files/avatars/, /setting), that doesn't use the fully specified ROOT_URL for loading. Those fail permanently to load. - You'll see that in the browsers console.

When you copy and change the URLs manually, then these resources are accessible without problems.

It's an issue with modules not using the ROOT_URL.

Correct.

@68040
Copy link
Author
68040 commented Apr 9, 2017

Same problem with attachments.

@68040 68040 changed the title Bug: Can't set language Bug: Some modules not using ROOT_URL Apr 12, 2017
This was referenced Apr 27, 2017
Closed
Closed
@xet7 xet7 mentioned this issue May 7, 2017
Closed
@xet7
Copy link
Member
xet7 commented May 7, 2017

Related to #386 and Meteor-Community-Packages/Meteor-CollectionFS#884

@GhassenRjab
Copy link
Contributor

I use Wekan 0.23 and I couldn't reproduce the issue to be able to debug it.
Is this issue specific to Wekan 0.18 or I missed something trying to reproduce?

@68040
Copy link
Author
68040 commented Jun 22, 2017 •
edited
Loading

or I missed something trying to reproduce?

The manual install of the release version?

There was a previous issue that belongs to this: #962 The discussion made some turns.

@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

Subdirectory problems. #133
@NoodleBB Please add (subdirectory/subfolder/prefixed paths) to the title.

@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

Language settings problem.

Related:

I think there is no problem.

diff --git a/client/lib/i18n.js b/client/lib/i18n.js
index 4c02211..97a9137 100644
--- a/client/lib/i18n.js
+++ b/client/lib/i18n.js
@@ -3,6 +3,7 @@
 // information provided by the browser, and default to english.
 
 Meteor.startup(() => {
+  TAPi18n.conf.i18n_files_route = Meteor._relativeToSiteRootUrl('/tap-i18n');
   Tracker.autorun(() => {
     const currentUser = Meteor.user();
     let language;

@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

Admin panel problem. (Subpath is missing in admin panel)

I think there is no problem.

diff --git a/client/components/users/userHeader.jade b/client/components/users/userHeader.jade
index 51b0888..84ef5a0 100644
--- a/client/components/users/userHeader.jade
+++ b/client/components/users/userHeader.jade
@@ -18,7 +18,7 @@ template(name="memberMenuPopup")
       li: a.js-change-language {{_ 'changeLanguagePopup-title'}}
       li: a.js-edit-notification {{_ 'editNotificationPopup-title'}}
     if currentUser.isAdmin
-      li: a.js-go-setting(href='/setting') {{_ 'admin-panel'}}
+      li: a.js-go-setting(href="{{pathFor 'setting'}}") {{_ 'admin-panel'}}
   hr
   ul.pop-over-list
     li: a.js-logout {{_ 'log-out'}}

This was referenced Jun 26, 2017
Merged
Merged
@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

Avatars problem (Subpath is missing in /cfs/files/avatars)
No problem.
image

@68040 68040 changed the title Bug: Some modules not using ROOT_URL Bug: Some modules not using ROOT_URL with subfolder Jun 26, 2017
xet7 added a commit that referenced this issue Jun 26, 2017
@xet7
Fix admin panel route for subfolder. Thanks to nztqa ! Related: #973
db9fc3c
xet7 added a commit that referenced this issue Jun 26, 2017
@xet7
Merge branch 'nztqa-fix-adminPanel-subfolder' into devel
6c9725a 
Fix admin panel route for subfolder. Thanks to nztqa ! Related: #973
xet7 added a commit that referenced this issue Jun 26, 2017
@xet7
Fix i18n route for subfolder. Thanks to nztqa ! Related: #973
1f80f96
xet7 added a commit that referenced this issue Jun 26, 2017
@xet7
Merge branch 'nztqa-fix-i18n-subfolder' into devel
2356ad8 
Fix i18n route for subfolder. Thanks to nztqa ! Related: #973
@xet7
Copy link
Member
xet7 commented Jun 26, 2017

Merged. Is this now fixed?

@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

@xet7 Please close this issue

@xet7 xet7 closed this as completed Jun 26, 2017
@zypA13510 zypA13510 mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xet7 @GhassenRjab @68040 @nztqa
0