8000 Bug: Releases missing submodules, leads to old bugs like: Appended double slashes to ROOT_URL · Issue #962 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug: Releases missing submodules, leads to old bugs like: Appended double slashes to ROOT_URL #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
68040 opened this issue Mar 31, 2017 · 49 comments
Closed

Bug: Releases missing submodules, leads to old bugs like: Appended double slashes to ROOT_URL #962

68040 opened this issue Mar 31, 2017 · 49 comments
Assignees
@xet7
Labels
Bug Severity:Stops-Work

Comments

@68040
Copy link
68040 commented Mar 31, 2017 •
edited
Loading

Problem: Bind Wekan to a path leads to double slashes in the URL, only when clicking on a card and when you to "export board".

Steps to reproduce:

  • Append path component to the Root URL. ROOT_URL=https://mydomain.org/wekan
  • Start Wekan. node ~/wekan/bundle/main.js
  • Open the URL in the browser. https://mydomain.org/wekan
  • Log-In into Wekan. Select a board. Create some random cards.
  • Then click on any card. - Error: "Page not found".

Finally: Inspect the URL and you'll find double slashes.
double slash

When you remove one of these slashes, you'll see the open dialog.

Rem.: This bug could be related to #907.
@68040 68040 mentioned this issue Mar 31, 2017
Closed
@xet7
Copy link
Member
xet7 commented Mar 31, 2017

@NoodleBB

What Wekan version are you using? This is already fixed #932

@68040
Copy link
Author
68040 commented Mar 31, 2017 •
edited
Loading

I think the latest version. Wekan v.0.17. - Is there a way to check that?

I'll reinstall the latest release... Yes. It's still there. Not fixed.

dubslash

@xet7
Copy link
Member
xet7 commented Mar 31, 2017

@Serubin

Can you look at this?

@68040
Copy link
Author
68040 commented Mar 31, 2017 •
edited
Loading

I've setup another Wekan demo that points out the problem. There you can test it for yourself.

The ROOT_URL is https://wekan008.serpens.uberspace.de/wekan.
Version: wekan-0.17

Demo-User: yeswekan
Demo-Pass: yeswekan99

The Demo Board.

Steps to reproduce:

  • When you click on the cards or try to export board via board menu, you'll encounter the "Page not found".
  • When you select and remove the second slash behind the "wekan//", then it works and you'll see the dialog.
  • Everything else seems to work as intended.

@xet7
Don't panic. The access data is just for demo purposes. This is not a production machine. User and all data will be destroyed within 30 days.

@Serubin
Copy link
Contributor
Serubin commented Apr 2, 2017 •
edited
Loading

@NoodleBB I took a look at the demo site you provided. It appears as the javascript is an older version. Make sure you properly rebuild wekan using the code below.

source app.env

# Rebuild meteor stuff
rm -rf .build
meteor build .build --directory

# Install depends
cd .build/bundle/programs/server
npm install

@xet7 Please close this issue

@68040
Copy link
Author
68040 commented Apr 2, 2017 •
edited
Loading

@xet7 @Serubin
It's still a bug in the release process. Because I've used the latest release version:
https://github.com/wekan/wekan/releases/download/v0.17/wekan-0.17.tar.gz

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

Releases get old quickly. I do tests and merges on devel head.

@xet7 xet7 closed this as completed Apr 2, 2017
@68040
Copy link
Author
68040 commented Apr 2, 2017 •
edited
Loading

@xet7
I use the latest release version and just follow the step in the manual installation. So currently there is a reproducable bug. 😕

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

Hmm, maybe I'll check it sometime.

@xet7 xet7 reopened this Apr 2, 2017
@xet7
Copy link
Member
xet7 commented Apr 2, 2017

Moved to #969

@xet7 xet7 closed this as completed Apr 2, 2017
@Serubin
Copy link
Contributor
Serubin commented Apr 2, 2017

@NoodleBB Downloading the tar likely does not download the required submodule and will default to using the default flow-router. Try pulling recursively using git and rebuilding.

@68040
Copy link
Author
68040 commented Apr 2, 2017

@Serubin The unit-tests should throw an error.

@xet7 xet7 reopened this Apr 2, 2017
@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

We don't have any unit tests.

@xet7 xet7 mentioned this issue Apr 2, 2017
Closed
@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

I moved your issue back to here.

We could have some checks and error messages for this.

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

Doh, it seems to be my problem. I did not update submodules for releases. I will update releases later.

@xet7 xet7 changed the title Bug: Appended double slashes to ROOT_URL Bug: Releases missing git submodules, leads to old bugs like: Appended double slashes to ROOT_URL Apr 2, 2017
@xet7 xet7 added the Bug label Apr 2, 2017
@68040
Copy link
Author
68040 commented Apr 2, 2017 •
edited
Loading

We don't have any unit tests.

Okay. This explain some things.

I moved your issue back to here.

No problem. Organise it the way, that you'll have the best overview. 🙂

We could have some checks and error messages for this.

Good idea. 👍

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

There could be some tests somewhere, but I have not tried to find them yet. Usually I just build Wekan and test does it work or does it crash. I keep Wekan devel head working.

Travis and Docker builds have some tests, but they are broken. I can build Wekan and it works great though.

@68040
Copy link
Author
68040 commented Apr 2, 2017

I know, writing unit-tests is boring.

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

@NoodleBB

I updated release v0.18 to include submodules. Can you test does that .tar.gz work for you now?

@68040
Copy link
Author
68040 commented Apr 2, 2017

Sure.

@68040
Copy link
Author
68040 commented Apr 2, 2017

Yes it works. 👍

@xet7
Copy link
Member
xet7 commented Apr 2, 2017

Great! :)

@xet7
Copy link
Member
xet7 commented Apr 7, 2017

@NoodleBB

I reopened #973 , it can be continued there.

@68040
Copy link
Author
68040 commented Apr 7, 2017

Perfect.

@68040 68040 changed the title Bug: Some modules not using ROOT_URL Bug: Releases missing submodules, leads to old bugs like: Appended double slashes to ROOT_URL Apr 7, 2017
@68040
Copy link
Author
68040 commented Apr 9, 2017 •
edited
Loading

Ok I made a script that regenerated all tar.gz releases and uploaded them.

So the doubleslash bug was reactivated 😞

@nztqa
Copy link
Contributor
nztqa commented Jun 26, 2017

The bug can't be reproduced.

wekan_url_double_slashes-iloveimg-compressed

@xet7 xet7 closed this as completed Jun 26, 2017
@rubberduck203
Copy link

This appears to be back.

It works in v0.24, but not in v0.25-v0.29.

@xet7
Copy link
Member
xet7 commented Jul 22, 2017

@nztqa

Can you reproduce this bug?

@xet7 xet7 reopened this Jul 22, 2017
@rubberduck203
Copy link

FWIW I was testing the docker builds from wekanteam/wekan.

@nztqa
Copy link
Contributor
nztqa commented Jul 22, 2017

It's just a docker problem

It starts from here.　f0f27d1#diff-3254677a7917c6c01f55212f86c57fbf

@xet7
Copy link
Member
xet7 commented Jul 22, 2017

@nztqa

Is it possible to fix that without adding git submodules back?

For example, should I fork whole meteor repo to Wekan and add changes to there directly?

@rubberduck203
Copy link

If I'm catching the drift, the cache isn't being invalidated. Is that correct?

@nztqa
Copy link
Contributor
nztqa commented Jul 22, 2017

Try with the same path as the source installation (https://github.com/wekan/wekan/wiki/Install-and-Update#install-and-build-wekan)

-    mkdir -p /home/wekan/.meteor/packages && ¥
+    mkdir -p /home/wekan/app/packages && ¥

xet7 added a commit that referenced this issue Jul 24, 2017
@xet7
Try to fix double slashes on Docker #962
4fdcc14
@xet7
Copy link
Member
xet7 commented Jul 24, 2017 •
edited
Loading

@nztqa

I tested with those changes and could not reproduce bug anymore. Is it fixed for you too, using wekanteam latest docker image?

@nztqa
Copy link
Contributor
nztqa commented Jul 24, 2017

OK.

@xet7
Copy link
Member
xet7 commented Jul 25, 2017

Fixed at 4fdcc14

@xet7 xet7 closed this as completed Jul 25, 2017
xet7 added a commit that referenced this issue Jul 25, 2017
@xet7
Fix double slashes on snap. Related #962
7b4970a
@xet7
Copy link
Member
xet7 commented Dec 20, 2017

This still happends when using snap, when I tried to add wekan to sub-url like example.com/wekan , and there was Drupal website at example.com . I'll try to apply previous fixes to this.

@xet7 xet7 reopened this Dec 20, 2017
@xet7 xet7 self-assigned this Dec 20, 2017
@xet7 xet7 mentioned this issue Dec 20, 2017
Open
xet7 added a commit that referenced this issue Jan 6, 2018
@xet7
Try to fix double slash on snap #962
428465d
@xet7
Copy link
Member
xet7 commented Jan 15, 2018

Please test newest Ubuntu Snap, is double slash bug now fixed.

It seems to work for me.

@xet7
Copy link
Member
xet7 commented Jan 15, 2018

With Nginx and Wekan at sub-url it works for me, there is no double slash bug, with Nginx and snap settings at this page:
https://github.com/wekan/wekan/wiki/Nginx-Webserver-Config

@xet7 xet7 closed this as completed Jan 15, 2018
@tobiasrenger-gh
Copy link

I'm running Wekan v0.71 (with Meteor v1.6.0.1) on Windows Server 2012 R2 (installed it from source).

If the environment variable ROOT_URL is set to http://localhost:3000 all URLs are fine. But when ROOT_URL is set to http://localhost:3000/wekan the links to the cards in the swimlane/activities-sidebar begin with http://localhost:3000/wekan//b/ (note the double slash after /wekan).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xet7 xet7

Labels
Bug < 4225 a id="label-7cea31" href="/wekan/wekan/labels/Severity%3AStops-Work" data-name="Severity:Stops-Work" style="--label-r:225;--label-g:29;--label-b:33;--label-h:358;--label-s:77;--label-l:49;" data-view-component="true" class="IssueLabel hx_IssueLabel width-fit mb-1 mr-1"> Severity:Stops-Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@xet7 @Serubin @rubberduck203 @68040 @nztqa @tobiasrenger-gh
0