8000 Fixed: Double slash problem by Serubin · Pull Request #932 · wekan/wekan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed: Double slash problem #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Fixed: Double slash problem #932

merged 4 commits into from
Mar 24, 2017

Conversation

Serubin
Copy link
Contributor
@Serubin Serubin commented Mar 23, 2017

This fixes issue #785 by adding a patched local version of kadira:flow-router to wekan. The flow-router fix is explained in issue #785.

I tested this in three instances, each was newly installed in it's own location. The urls that were tested are as follows: example.com/wekan, brd.example.com/wekan, brd.example.com.

It's important to note that when building or starting the server it is required to execute the following command to export the local package directory for meteor: source app.env. All worked as expected.

The patched flow-router repo can be transferred to the wekan namespace upon request.


This change is Reviewable

@CLAassistant
Copy link
CLAassistant commented Mar 23, 2017

CLA assistant check
All committers have signed the CLA.

@Serubin
Copy link
Contributor Author
Serubin commented Mar 23, 2017

Eslint was erroring on flow-router. I've changed the test command to ignore the packages/ directory to avoid this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0