8000 chore: parametrize import test by maciejmajek · Pull Request #402 · RobotecAI/rai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: parametrize import test #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

maciejmajek
Copy link
Member

Purpose

Previously, the import tests would fail on the first encounter of bad import. This behavior caused tests to be skipped delivering reduced amount of information to the developer.

Proposed Changes

Splits the tests per module.

@maciejmajek maciejmajek requested a review from rachwalk February 3, 2025 16:30
Copy link
Contributor
@rachwalk rachwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejmajek maciejmajek merged commit 6bae47f into development Feb 4, 2025
5 checks passed
@maciejmajek maciejmajek deleted the chore/split-smoke-tests branch February 4, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0