8000 refactor: connector api by maciejmajek · Pull Request #532 · RobotecAI/rai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: connector api #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

refactor: connector api #532

merged 5 commits into from
Apr 17, 2025

Conversation

maciejmajek
Copy link
Member
@maciejmajek maciejmajek commented Apr 16, 2025

Purpose

To enhance developer experience through api changes that make sense.

Proposed Changes

  • Refactored BaseConnector and BaseMessage
  • Introduced callback handling mechanism in BaseConnector
  • Refactored ROS2TopicAPI
  • Removed "ARI"

TODO in the next PR:

  • Remove ConfigurableTopicAPI (as refactored ROS2Connector have the same capabilities)
  • Refactor code relying on ConfigurableTopicAPI

Issues

  • Links to relevant issues

Testing

CI, new tests

WIP- not a draft to monitor CI

@maciejmajek maciejmajek changed the title refactor: connector api [WIP] refactor: connector api Apr 17, 2025
@maciejmajek maciejmajek merged commit 5532c2f into development Apr 17, 2025
5 checks passed
@maciejmajek maciejmajek deleted the refactor/base branch April 17, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0