refactor: remove navigation tasks #638
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fa85fd to
f84f5b6
Compare
29f9061 to
889e323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Navigational tasks are hard to validate or even impossible to validate based solely on tool calls. Unlike manipulation, where we have a tool Manipulator move to, here the agent is operating on nav2 actions which makes it harder to validate. Additionally in navigation there can be nearly infinite number of ways to drive somewhere. For example to move 20cm forward i can call move 10cm forward action 2 times and it would result in the same movement, therefor we can't say that the 2nd approach is wrong.
Proposed Changes
Based on that i decided to remove navigation tasks from tool calling benchmark. If you would want to have benchmark for navigation in the future, i think it makes much more sense to validate it via end result in simulation environment.
Issues
Partially #576
Testing