feat: agriculture demo #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ff6faa to
da25506
Compare
boczekbartek
requested changes
Oct 20, 2024
| ) | ||
|
|
||
|
|
||
| class Ros2GenericServiceCaller(Ros2BaseTool): |
There was a problem hiding this comment.
Please inherit from Ros2AsyncBaseTool:
Also, please register this tool here:
Line 412 in 0333ea2
I can see that you spin the tool inside _run. If this tool is attached directly to Rai2BaseNode, it might cause deadlock / rclpy errors, because RaiBaseNode is usually being spinned already.
maciejmajek
commented
Oct 20, 2024
boczekbartek
requested changes
Oct 20, 2024
acd09bd to
2ed7039
Compare
boczekbartek
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding agriculture demo
Proposed Changes
Adds:
Issues
Testing