8000 chore: update poetry install link with fixed version by maciejmajek · Pull Request #358 · RobotecAI/rai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update poetry install link with fixed version #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore: update poetry install link with fixed version #358

merged 1 commit into from
Jan 8, 2025

Conversation

maciejmajek
Copy link
Member

Purpose

Poetry just published 2.0 version, introducing multiple breaking changes e.g. shell removal.

Proposed Changes

Updates poetry installation link to use fixed 1.8.4 version.

Testing

  • curl -sSL https://install.python-poetry.org | python3 - --version 1.8.4
  • poetry install

maciejmajek
maciejmajek commented Jan 8, 2025
View reviewed changes
@boczekbartek boczekbartek self-requested a review January 8, 2025 13:21
@boczekbartek
Copy link
Member
boczekbartek commented Jan 8, 2025 •
edited
Loading

@maciejmajek Please fix pre-commit, otherwise approved

@maciejmajek
Copy link
Member Author

Thank you @boczekbartek for reviewing this PR in such a timely manner. I've fixed the cause of previous pre-commit fail.

@maciejmajek maciejmajek merged commit 9c2c514 into development Jan 8, 2025
5 checks passed
@maciejmajek maciejmajek deleted the maciejmajek-patch-1 branch January 8, 2025 13:26
@boczekbartek
Copy link
Member

@maciejmajek do you know when poetry is installed using the new command?
I tested it again and poetry is not installed correctly:

$ curl -sSL https://install.python-poetry.org | python3 - --version 1.8.4
Retrieving Poetry metadata

The latest version (1.8.4) is already installed.

$ poetry
zsh: command not found: poetry

@boczekbartek
Copy link
Member

I think the problem might have been on my side, but I had a missing symlink in ~/.local/bin:

poetry -> /home/bboczek/.local/share/pypoetry/venv/bin/poetry

I fixed it with:

cd ~/.local/bin
rm poetry
curl -sSL https://install.python-poetry.org | python3 -  # this was required because the next command stated that poetry is already installed
curl -sSL https://install.python-poetry.org | python3 - --version 1.8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boczekbartek boczekbartek boczekbartek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejmajek @boczekbartek
0