8000 chore: remove skipped test by rachwalk · Pull Request #392 · RobotecAI/rai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove skipped test #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

rachwalk
Copy link
Contributor
@rachwalk rachwalk commented Jan 28, 2025

Purpose

The test checks is skipped, because it was added to decide what is the expected behaviour if callback terminates after the action which called it. The expected behaviour doesn't require testing. The test should be removed.

Proposed Changes

Removes the test in question.

Issues

#381

Testing

N/A

Copy link
Member
@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj

@rachwalk rachwalk merged commit 7ca87dd into development Jan 28, 2025
7 checks passed
@rachwalk rachwalk deleted the chore/remove-callback-shutdown-test branch January 28, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0