8000 fix: list-remote --filter --latest panics when filter has no results by julescubtree · Pull Request #1184 · Schniz/fnm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: list-remote --filter --latest panics when filter has no results #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

julescubtree
Copy link
Contributor

This PR checks for results before modifying the all_versions vector, and opts for .swap() and .truncate() over .drain() to reduce overhead and improve efficiency.

Copy link
changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 6630bf1

The changes in this PR will be included in the 8000 next version bump.

This PR includes changesets to release 1 package
Name Type
fnm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fnm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:13am

Copy link
Owner
@Schniz Schniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
i'll add a test :)

@Schniz Schniz merged commit fefdf69 into Schniz:master Oct 6, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0