Schniz · Schniz · Oct 6, 2024 · Jun 16, 2024 · Jun 22, 2024 · Jun 22, 2024
diff --git a/.changeset/plenty-flies-refuse.md b/.changeset/plenty-flies-refuse.md
@@ -0,0 +1,5 @@
+---
+"fnm": patch
+---
+
+fix panic when list-remote --filter --latest has no results
diff --git a/src/commands/ls_remote.rs b/src/commands/ls_remote.rs
@@ -35,6 +35,15 @@ pub enum SortingMethod {
     Ascending,
 }
 
+/// Drain all elements but the last one
+fn truncate_except_latest<T>(list: &mut Vec<T>) {
+    let len = list.len();
+    if len > 1 {
+        list.swap(0, len - 1);
+        list.truncate(1);
+    }
+}
+
 impl super::command::Command for LsRemote {
     type Error = Error;
 
@@ -57,7 +66,7 @@ impl super::command::Command for LsRemote {
         }
 
         if self.latest {
-            all_versions.drain(0..all_versions.len() - 1);
+            truncate_except_latest(&mut all_versions);
         }
 
         if let SortingMethod::Descending = self.sort {
@@ -89,3 +98,23 @@ pub enum Error {
         source: crate::http::Error,
     },
 }
+
+#[cfg(test)]
+mod test {
+    use super::*;
+
+    #[test]
+    fn test_truncate_except_latest() {
+        let mut list = vec![1, 2, 3, 4, 5];
+        truncate_except_latest(&mut list);
+        assert_eq!(list, vec![5]);
+
+        let mut list: Vec<()> = vec![];
+        truncate_except_latest(&mut list);
+        assert_eq!(list, vec![]);
+
+        let mut list = vec![1];
+        truncate_except_latest(&mut list);
+        assert_eq!(list, vec![1]);
+    }
+}