8000 feat: Use Conan 2 by mathbunnyru · Pull Request #2179 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Use Conan 2 #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

feat: Use Conan 2 #2179

merged 3 commits into from
Jun 6, 2025

Conversation

mathbunnyru
Copy link
Collaborator
@mathbunnyru mathbunnyru commented Jun 2, 2025 •
edited
Loading

Merge right after: #2178
Waits for: XRPLF/rippled#5462

@mathbunnyru
Copy link
Collaborator Author

All the changes from ghcr.io/xrplf/clio-ci:latest to ghcr.io/mathbunnyru/clio-ci:latest are to be able to test it in PR before merging CI image here.

mathbunnyru
mathbunnyru commented Jun 2, 2025
View reviewed changes
@mathbunnyru mathbunnyru closed this Jun 2, 2025
@mathbunnyru mathbunnyru reopened this Jun 2, 2025
@mathbunnyru mathbunnyru closed this Jun 2, 2025
@mathbunnyru mathbunnyru reopened this Jun 2, 2025
@mathbunnyru mathbunnyru force-pushed the use_conan2 branch 3 times, most recently from 0d35c92 to ce1e133 Compare June 2, 2025 17:06
@mathbunnyru mathbunnyru closed this Jun 2, 2025
@mathbunnyru mathbunnyru reopened this Jun 2, 2025
@mathbunnyru mathbunnyru force-pushed the use_conan2 branch 3 times, most recently from 9589c1f to f529ef5 Compare June 2, 2025 19:16
@codecov Codecov
Copy link
codecov bot commented Jun 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (13524be) to head (010b66a).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2179   +/-   ##
========================================
  Coverage    73.27%   73.27%           
========================================
  Files          368      368           
  Lines        14977    14977           
  Branches      7595     7595           
========================================
  Hits         10975    10975           
  Misses        1897     1897           
  Partials      2105     2105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru closed this Jun 2, 2025
@mathbunnyru mathbunnyru reopened this Jun 2, 2025
@mathbunnyru mathbunnyru force-pushed the use_conan2 branch 3 times, most recently from 0c7e2c2 to 4aebea0 Compare June 3, 2025 13:03
@mathbunnyru mathbunnyru closed this Jun 3, 2025
@mathbunnyru mathbunnyru reopened this Jun 3, 2025
godexsoft
godexsoft requested changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions, nothing major.

@mathbunnyru mathbunnyru force-pushed the use_conan2 branch 3 times, most recently from 8048082 to 0b0d425 Compare June 6, 2025 16:18
godexsoft
godexsoft reviewed Jun 6, 2025 8000
View reviewed changes
@godexsoft godexsoft mentioned this pull request Jun 6, 2025
Merged
1 task
godexsoft
godexsoft approved these changes Jun 6, 2025
View reviewed changes
Copy link
Collaborator
@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rage4:

@mathbunnyru mathbunnyru merged commit a68229e into XRPLF:develop Jun 6, 2025
29 of 42 checks passed
@mathbunnyru mathbunnyru mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godexsoft godexsoft godexsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathbunnyru @godexsoft
0