fix: Specify transitive_headers when building with Conan 2 #5462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5462 +/- ##
=======================================
Coverage 79.0% 79.0%
=======================================
Files 817 817
Lines 71737 71737
Branches 8313 8313
=======================================
Hits 56656 56656
Misses 15081 15081 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
legleux
approved these changes
Jun 3, 2025
bthomee
approved these changes
Jun 3, 2025
mathbunnyru
added a commit
to XRPLF/clio
that referenced
this pull request
Jun 6, 2025
Merge right after: #2178 Waits for: XRPLF/rippled#5462
This was referenced Jun 12, 2025
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
To be able to consume
rippledin Conan 2, the recipe should specifytransitive_headersfor external libraries which are present in the exported header files.I implement it in a way not to break compatibility with Conan 1, where this flag was not present.
https://docs.conan.io/2/tutorial/creating_packages/add_dependencies_to_packages.html#tutorial-create-packages-headers-transitivity
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)