fix: Use new CI image with global.conf for sanitizers to affect packa… #2234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Jun 17, 2025
godexsoft
previously approved these changes
Jun 17, 2025
godexsoft
approved these changes
Jun 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2234 +/- ##
===========================================
- Coverage 73.20% 73.19% -0.02%
===========================================
Files 370 370
Lines 15099 15099
Branches 7667 7667
===========================================
- Hits 11053 11051 -2
+ Misses 1920 1919 -1
- Partials 2126 2129 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
added a commit
that referenced
this pull request
Jun 18, 2025
The issue is that we previously didn't care about `[conf]` section. And for example, we uploaded `clang.ubsan` build with the same package_id as a regular clang build. This was fixed in #2233 and #2234 Adding `global.conf` almost fixed the problem, but since our non-sanitized builds don't set anything in `[conf]`, we use the same package_id as before. So, for the `clang` build we end up with previously uploaded `clang.ubsan` build artifacts. To fix this, we should force the upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge_id