fix: Force reupload new artifacts #2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
approved these changes
Jun 18, 2025
godexsoft
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that we previously didn't care about
[conf]section.And for example, we uploaded
clang.ubsanbuild with the same package_id as a regular clang build.This was fixed in #2233 and #2234
Adding
global.confalmost fixed the problem, but since our non-sanitized builds don't set anything in[conf], we use the same package_id as before.So, for the
clangbuild we end up with previously uploadedclang.ubsanbuild artifacts.To fix this, we should force the upload.