Changed the interface of placement objects to include subcluster information #4355
+656
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
|
|
||
| // BySubClusterIDInstanceID is a type that implements sort.Interface for a slice of placement.Instance | ||
| // It sorts instances first by subcluster ID, then by instance ID within each subcluster | ||
| type BySubClusterIDInstanceID []Instance |
There was a problem hiding this comment.
for simplicity should we rename it to "BySubClusterIDThenInstanceID"
| maxShardSetID uint32 | ||
| isSharded bool | ||
| isMirrored bool | ||
| hasSubClusters bool |
There was a problem hiding this comment.
Should we rename this to "isSubClusteringEnabled" or some 7686 thing similar which aligns more with the existing variables like "isSharded" and "isMirrored"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this stack we are introducing the concept of sub-clusters within a cluster's placement. The instances in the placement will be divided into sub-clusters and each sub-cluster will have the ownership of some shards that are assigned to it.
The sub-clustered placement will have the property of instances per sub-cluster (multiple of replication factor), and all the replicas of the shard assigned to a sub-cluster will be distributed among the instances in the sub-cluster. This will reduce the probability of any two nodes going down in the cluster to causing a write outage.
This PR changes the proto file, placement interface, Instance interface, corresponding mocks and implementation. Fixes of unit test affected by new fields have also been changed.
Each Instance will now have one more field:
The placement object will have two new fields:
Similarly the Options interface will also have the same new methods/fields as placement to pass these values to the placement during Initial placement.