8000 Added code for validating subclustered placement by RiyaTyagi · Pull Request #4362 · m3db/m3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added code for validating subclustered placement #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sub-cluster-6
Choose a base branch
from
Open

Added code for validating subclustered placement #4362

wants to merge 2 commits into from

Conversation

RiyaTyagi
Copy link
Collaborator
@RiyaTyagi RiyaTyagi commented Jun 27, 2025 •
edited
Loading

What this PR does / why we need it:

After adding the code for InitialPlacement we need to make sure that the placement is valid and this PR adds the code to validate subclustered placement.

Following validations have been added:

  • If the placement is subclustered it has to be sharded.
  • If the placement is subclustered then each instance should have a subcluster ID > 0 and vice versa. 0 is the default value.
  • All the replicas of the shard should belong to same subcluster, only when we are adding or removing a subcluster and it hasn't been added/removed completely a shard can belong to two subclusters.
  • Each shard should belong to different isolation group.

@RiyaTyagi git-spice
Copy link
Collaborator Author
RiyaTyagi commented Jun 27, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

This was referenced Jun 27, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@RiyaTyagi RiyaTyagi force-pushed the sub-cluster-7 branch 2 times, most recently from a2a9efb to 6ff23d1 Compare June 30, 2025 10:58
@RiyaTyagi RiyaTyagi marked this pull request as ready for review June 30, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RiyaTyagi
0