build using Py3.8 and test across more OSs #506
Conversation
d97d7ac to
0bca626
Compare
|
now this also runs on Windows 7 capa.exe 478040c |
| @@ -26,10 +29,11 @@ jobs: | |||
| uses: actions/checkout@v2 | |||
| with: | |||
| submodules: true | |||
| - name: Set up Python 3.9 | |||
| # using Python 3.8 to support running across multiple operating systems including Windows 7 | |||
|
whats our status here? |
|
If we're fine with Python 3.8 I can remove the testing code and get this set up before the next release. |
|
bump @Ana06 and @williballenthin |
| @@ -45,10 +46,38 @@ jobs: | |||
| name: ${{ matrix.asset_name }} | |||
| path: dist/${{ matrix.artifact_name }} | |||
|
|
|||
| test_run: | |||
There was a problem hiding this comment.
I do not really like to test this in the build workflow. I mean, we release and if any OS fails we don't upload any binary. It would be better to test this before releasing. What about adding a test build workflow which is run in master (which should be green before releasing) and removing it from here?
There was a problem hiding this comment.
hm, how can we do this on a per-case basis? maybe via a specific activity type https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release?
There was a problem hiding this comment.
What do you mean? running it only on a release PR?
My proposal was to create a build_test.yml which is run on master:
on:
push:
branches:
- master
alternatively we could test it on every PR
There was a problem hiding this comment.
Instead of duplicating steps in a new workflow file my new proposal uses if checks to test_run on push to master or to zip on release.
.github/workflows/build.yml
Outdated
| @@ -45,10 +48,40 @@ jobs: | |||
| name: ${{ matrix.asset_name }} | |||
| path: dist/${{ matrix.artifact_name }} | |||
|
|
|||
| test_run: | |||
| if: github.event_name == 'push' && github.ref == 'refs/heads/master' | |||
There was a problem hiding this comment.
do this step on push to master
There was a problem hiding this comment.
I think github.event_name == 'push' should be enough because this only runs in master
| zip: | ||
| if: github.event_name == 'release' |
There was a problem hiding this comment.
do this only for release events
.github/workflows/build.yml
Outdated
| @@ -45,10 +48,40 @@ jobs: | |||
| name: ${{ matrix.asset_name }} | |||
| path: dist/${{ matrix.artifact_name }} | |||
|
|
|||
| test_run: | |||
| if: github.event_name == 'push' && github.ref == 'refs/heads/master' | |||
There was a problem hiding this comment.
I think github.event_name == 'push' should be enough because this only runs in master
.github/workflows/build.yml
Outdated
| @@ -75,9 +78,10 @@ jobs: | |||
| run: ./${{ matrix.artifact_name }} -h | |||
|
|
|||
| zip: | |||
There was a problem hiding this comment.
zip_and_upload may be a better name for this (although this was not modified in this PR)
There was a problem hiding this comment.
updated this and the 'push' check, thanks!
|
Done! |
closes #505
also further discussion is warranted