8000 Release v1.6.2 building with Python 3.8 by Ana06 · Pull Request #527 · mandiant/capa · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release v1.6.2 building with Python 3.8 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 13, 2021
Merged

Release v1.6.2 building with Python 3.8 #527

merged 4 commits into from
Apr 13, 2021

Conversation

Ana06
Copy link
Member
@Ana06 Ana06 commented Apr 13, 2021 •
edited
Loading

I have created a master-py2 branch to backports fixes to Python2. This PR includes:

Release checklist (note some things don't apply in this case)

  • Ensure all milestoned issues/PRs are addressed, or reassign to a new milestone. It doesn't apply (no milestone)
  • Add the dont merge label to all PRs that are close to be ready to merge (or merge them if they are ready) in capa and capa-rules. It doesn't apply (we are not releasing master, but master-py2)
  • Ensure the CI workflow succeeds in master. We don't run tests for master-py2 until we merge this PR, but current master-py2 is v1.6.1 and we know tests work.
  • Ensure that python scripts/lint.py rules/ --thorough succeeds (only missing examples offenses are allowed in the nursery). Current master-py2 is v1.6.1 and we know it works.
  • Review changes No changes to review, all of them are included in this PR
  • Update CHANGELOG.md
    • Do not forget to add a nice introduction thanking contributors
    • Remember that we need a major release if we introduce breaking changes
    • Sections
      • New Features
      • New Rules
      • Bug Fixes
      • Changes
      • Development
      • Raw diffs
    • Update Raw diffs links
    • Create placeholder for master (unreleased) section 
      ## master (unreleased)

### New Features

### New Rules

### Bug Fixes

### Changes

### Development

### Raw diffs
- [capa <release>...master](https://github.com/fireeye/capa/compare/<release>...master)
- [capa-rules <release>...master](https://github.com/fireeye/capa-rules/compare/<release>...master)
  • Update capa/version.py
  • Create a PR with the updated CHANGELOG.md and capa/version.py. Copy this checklist in the PR description.< 8000 /li>
  • After PR review, merge the PR and create the release in GH using text from the CHANGELOG.md.
  • Verify GH actions upload artifacts, publish to PyPI and create a tag in capa rules upon completion.
  • Spread the word I don't think this is needed

Documentation

  • I have updated the CHANGELOG.md, this is required for:
    • Bug fixes (non-breaking change which fixes an issue)
    • New features (non-breaking change which adds functionality)
    • Breaking changes (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made the corresponding changes to the documentation

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • No new tests needed
    Python 3.9 doesn't support Windows 7. Build with Python 3.8 instead.

Ana06 added 4 commits April 13, 2021 12:06
@Ana06
build: Fix binary for Windows 7
b34d791 
Python 3.9 doesn't support Windows 7. Build with Python 3.8 instead.
@Ana06
ci: Enable tests for master-py2 branch
62743e1 
Use the master-py branch to backport fixes to capa 1.6 (Python 2
support).
@Ana06
version: bump to v1.6.2
54f8f6d
@Ana06
changelog: v1.6.2
60834e3 
This release backports a fix to capa 1.6: The Windows binary was built
with Python 3.9 which doesn't support Windows 7.
@Ana06 Ana06 requested review from williballenthin and mr-tz April 13, 2021 10:30
@Ana06 Ana06 merged commit eea0e1e into mandiant:master-py2 Apr 13, 2021
@Ana06 Ana06 deleted the v1-6-2 branch April 13, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz approved these changes

@williballenthin williballenthin Awaiting requested review from williballenthin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ana06 @mr-tz
0